fix(TableToolbarSearch): allow screen reader navigation #7986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @carmacleod |
emyarod
force-pushed
the
7915-datatable-search-bar-screen-reader-support
branch
from
fb11275
to
de8f05e
Compare
|
Deploy preview for carbon-elements ready! Built with commit 99dddeb |
|
Deploy preview for carbon-components-react ready! Built with commit 99dddeb https://deploy-preview-7986--carbon-components-react.netlify.app |
jnm2377
approved these changes
Mar 5, 2021
jnm2377
requested review from
a team and
johnbister
and removed request for
a team
tay1orjones
approved these changes
Mar 8, 2021
dakahn
approved these changes
Mar 8, 2021
emyarod
requested review from
a team and
jeanservaas
and removed request for
johnbister and
a team
|
This PR currently has a merge conflict. Please resolve this and then re-add the |
carmacleod
approved these changes
Mar 29, 2021
emyarod
force-pushed
the
7915-datatable-search-bar-screen-reader-support
branch
from
de8f05e
to
99dddeb
Compare
|
DCO Assistant Lite bot: Thanks for your submission! We ask that you sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text: I have read the DCO document and I hereby sign the DCO. You can retrigger this bot by commenting recheck in this Pull Request |
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7915
This PR removes the div wrapper around the table toolbar search component so that screen readers can focus on the input field. The search bar transitions are also fixed so that expanding the search bar now animates properly as well
Changelog
Testing / Reviewing
Confirm that the table toolbar search behavior and appearance matches the current component on top of being screen reader accessible